Add case to capture enum subtype reduction (addresses #35867)#49675
Merged
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom Jun 24, 2022
Merged
Add case to capture enum subtype reduction (addresses #35867)#49675RyanCavanaugh merged 1 commit intomicrosoft:mainfrom
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom
Conversation
#68) * Add case to capture enum subtype reduction (addresses microsoft#35867) Signed-off-by: Lawrence Craft <[email protected]>
|
|
Member
|
Oops, please sign the CLA so I don't have to revert that... |
Contributor
|
@RyanCavanaugh CLA bot used to auto-accept PRs coming from the Bloomberg fork. Do you know if anything changed related to that? We have seen it not working on this PR and also in #49649, #49639, #49636. |
Member
|
That happens to be the thing I'm working on right now 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
I've added a few tests to address the behavior described in #35867. The issue itself is fixed, but these tests will help catch regressions. Once this is merged the bug should be able to be closed.
Testing performed
I added cases for lots of permutations of this subtype reduction and checked the output to ensure the correct types were being returned. Everything looked good, including Typescript cleverly narrowing to unions of enums when values are falsy and the || operator would filter them out.
Thanks to @acutmore and @mkubilayk for the reviews and help on this!
Fixes #35867